Add error message to catch a plugin being added as a middleware#349
Add error message to catch a plugin being added as a middleware#349rajeshsegu wants to merge 2 commits intomasterfrom
Conversation
rajeshsegu
changed the title
KevinGrandon
left a comment
KevinGrandon
left a comment
There was a problem hiding this comment.
On the fence about this one as it seems that flow does catch this case. I'm not sure we want to try to implement runtime checks for everything that we do have flow types for, but let's see what people think.
|
Need to fix flow error. Also, this is not greenkeeping. I'd say bugfix might be a more appropriate tag. @KevinGrandon I think it's ok to add runtime checks for these, at least for now. We've had a few cases of post-migration code throwing bad errors and wasting people's time that could've been avoided by surfacing errors such as this. Also, the test suite already has a lot of tests similar to this one. |
KevinGrandon
left a comment
KevinGrandon
left a comment
There was a problem hiding this comment.
Ok, works for me then. Requesting changes to clear review queue. Let's get flow issues fixed and request re-reivew. Thanks!
Codecov Report
@@ Coverage Diff @@
## master #349 +/- ##
=========================================
Coverage ? 93.23%
=========================================
Files ? 18
Lines ? 458
Branches ? 92
=========================================
Hits ? 427
Misses ? 17
Partials ? 14
Continue to review full report at Codecov.
|
|
@KevinGrandon @lhorie please do review ( updated tag to bugfix and flow passes ) |
3 participants
No description provided.